refactor

core/identity/application/use-cases/SignupUseCase.ts

@@ -26,26 +26,24 @@ export type SignupApplicationError = ApplicationErrorCode<SignupErrorCode, { mes
  *
  * Handles user registration.
  */
-export class SignupUseCase implements UseCase<SignupInput, SignupResult, SignupErrorCode> {
+export class SignupUseCase implements UseCase<SignupInput, void, SignupErrorCode> {
   constructor(
     private readonly authRepo: IAuthRepository,
     private readonly passwordService: IPasswordHashingService,
     private readonly logger: Logger,
-    private readonly output: UseCaseOutputPort<Result<SignupResult, SignupApplicationError>>,
+    private readonly output: UseCaseOutputPort<SignupResult>,
   ) {}
 
-  async execute(input: SignupInput): Promise<Result<SignupResult, SignupApplicationError>> {
+  async execute(input: SignupInput): Promise<Result<void, SignupApplicationError>> {
     try {
       const emailVO = EmailAddress.create(input.email);
 
       const existingUser = await this.authRepo.findByEmail(emailVO);
       if (existingUser) {
-        const result = Result.err<SignupResult, SignupApplicationError>({
+        return Result.err({
           code: 'USER_ALREADY_EXISTS',
           details: { message: 'User already exists' },
         });
-        this.output.present(result);
-        return result;
       }
 
       const hashedPassword = await this.passwordService.hash(input.password);
@@ -62,9 +60,8 @@ export class SignupUseCase implements UseCase<SignupInput, SignupResult, SignupE
 
       await this.authRepo.save(user);
 
-      const result = Result.ok<SignupResult, SignupApplicationError>({ user });
-      this.output.present(result);
-      return result;
+      this.output.present({ user });
+      return Result.ok(undefined);
     } catch (error) {
       const message =
         error instanceof Error && error.message
@@ -75,12 +72,10 @@ export class SignupUseCase implements UseCase<SignupInput, SignupResult, SignupE
         input,
       });
 
-      const result = Result.err<SignupResult, SignupApplicationError>({
+      return Result.err({
         code: 'REPOSITORY_ERROR',
         details: { message },
       });
-      this.output.present(result);
-      return result;
     }
   }
 }