refactor

core/analytics/application/use-cases/RecordPageViewUseCase.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect, vi, type Mock } from 'vitest';
-import { RecordPageViewUseCase, type RecordPageViewInput } from './RecordPageViewUseCase';
+import { RecordPageViewUseCase, type RecordPageViewInput, type RecordPageViewOutput } from './RecordPageViewUseCase';
 import type { IPageViewRepository } from '../../domain/repositories/IPageViewRepository';
 import { PageView } from '../../domain/entities/PageView';
 import type { Logger, UseCaseOutputPort } from '@core/shared/application';
@@ -11,7 +11,7 @@ describe('RecordPageViewUseCase', () => {
     save: Mock;
   };
   let logger: Logger;
-  let output: UseCaseOutputPort<Result<any, any>> & { present: Mock };
+  let output: UseCaseOutputPort<RecordPageViewOutput> & { present: Mock };
   let useCase: RecordPageViewUseCase;
 
   beforeEach(() => {
@@ -32,8 +32,8 @@ describe('RecordPageViewUseCase', () => {
 
     useCase = new RecordPageViewUseCase(
       pageViewRepository as unknown as IPageViewRepository,
-      output,
       logger,
+      output,
     );
   });
 
@@ -51,8 +51,9 @@ describe('RecordPageViewUseCase', () => {
 
     pageViewRepository.save.mockResolvedValue(undefined);
 
-    await useCase.execute(input);
+    const result = await useCase.execute(input);
 
+    expect(result.isOk()).toBe(true);
     expect(pageViewRepository.save).toHaveBeenCalledTimes(1);
     const saved = (pageViewRepository.save as unknown as Mock).mock.calls[0][0] as PageView;
 
@@ -61,6 +62,9 @@ describe('RecordPageViewUseCase', () => {
     expect(saved.entityId).toBe(input.entityId);
     expect(saved.entityType).toBe(input.entityType);
 
+    expect(output.present).toHaveBeenCalledWith({
+      pageViewId: saved.id,
+    });
     expect((logger.info as unknown as Mock)).toHaveBeenCalled();
   });
 
@@ -75,8 +79,9 @@ describe('RecordPageViewUseCase', () => {
     const error = new Error('DB error');
     pageViewRepository.save.mockRejectedValue(error);
 
-    await useCase.execute(input);
+    const result = await useCase.execute(input);
 
+    expect(result.isErr()).toBe(true);
     expect((logger.error as unknown as Mock)).toHaveBeenCalled();
   });
 });