refactor

core/analytics/application/use-cases/GetAnalyticsMetricsUseCase.ts

@@ -1,7 +1,7 @@
-import type { Logger, UseCaseOutputPort, UseCase } from '@core/shared/application';
-import type { IPageViewRepository } from '../../domain/repositories/IPageViewRepository';
+import type { Logger, UseCase, UseCaseOutputPort } from '@core/shared/application';
 import { Result } from '@core/shared/application/Result';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
+import type { IPageViewRepository } from '../../domain/repositories/IPageViewRepository';
 
 export interface GetAnalyticsMetricsInput {
   startDate?: Date;
@@ -17,25 +17,33 @@ export interface GetAnalyticsMetricsOutput {
 
 export type GetAnalyticsMetricsErrorCode = 'REPOSITORY_ERROR';
 
-export class GetAnalyticsMetricsUseCase implements UseCase<GetAnalyticsMetricsInput, GetAnalyticsMetricsOutput, GetAnalyticsMetricsErrorCode> {
+export class GetAnalyticsMetricsUseCase implements UseCase<GetAnalyticsMetricsInput, void, GetAnalyticsMetricsErrorCode> {
   constructor(
     private readonly pageViewRepository: IPageViewRepository,
     private readonly logger: Logger,
+    private readonly output: UseCaseOutputPort<GetAnalyticsMetricsOutput>,
   ) {}
 
-  async execute(input: GetAnalyticsMetricsInput = {}): Promise<Result<GetAnalyticsMetricsOutput, ApplicationErrorCode<GetAnalyticsMetricsErrorCode, { message: string }>>> {
+  async execute(input: GetAnalyticsMetricsInput = {}): Promise<Result<void, ApplicationErrorCode<GetAnalyticsMetricsErrorCode, { message: string }>>> {
     try {
       const startDate = input.startDate ?? new Date(Date.now() - 30 * 24 * 60 * 60 * 1000); // 30 days ago
       const endDate = input.endDate ?? new Date();
 
-      // For now, return placeholder values as actual implementation would require
-      // aggregating data across all entities or specifying which entity
-      // This is a simplified version
+      // TODO static data
       const pageViews = 0;
       const uniqueVisitors = 0;
       const averageSessionDuration = 0;
       const bounceRate = 0;
 
+      const resultModel: GetAnalyticsMetricsOutput = {
+        pageViews,
+        uniqueVisitors,
+        averageSessionDuration,
+        bounceRate,
+      };
+
+      this.output.present(resultModel);
+
       this.logger.info('Analytics metrics retrieved', {
         startDate,
         endDate,
@@ -43,21 +51,14 @@ export class GetAnalyticsMetricsUseCase implements UseCase<GetAnalyticsMetricsIn
         uniqueVisitors,
       });
 
-      const result = Result.ok<GetAnalyticsMetricsOutput, ApplicationErrorCode<GetAnalyticsMetricsErrorCode, { message: string }>>({
-        pageViews,
-        uniqueVisitors,
-        averageSessionDuration,
-        bounceRate,
-      });
-      return result;
+      return Result.ok(undefined);
     } catch (error) {
       const err = error as Error;
       this.logger.error('Failed to get analytics metrics', err, { input });
-      const result = Result.err<GetAnalyticsMetricsOutput, ApplicationErrorCode<GetAnalyticsMetricsErrorCode, { message: string }>>({
+      return Result.err({
         code: 'REPOSITORY_ERROR',
         details: { message: err.message ?? 'Failed to get analytics metrics' },
       });
-      return result;
     }
   }
 }