refactor

apps/api/src/domain/protests/ProtestsController.ts

@@ -2,6 +2,7 @@ import { Body, Controller, ForbiddenException, HttpCode, HttpStatus, InternalSer
 import { ApiOperation, ApiParam, ApiResponse, ApiTags } from '@nestjs/swagger';
 import { ProtestsService } from './ProtestsService';
 import { ReviewProtestCommandDTO } from '../race/dtos/ReviewProtestCommandDTO';
+import type { ReviewProtestResponseDTO } from './presenters/ReviewProtestPresenter';
 
 @ApiTags('protests')
 @Controller('protests')
@@ -17,19 +18,18 @@ export class ProtestsController {
     @Param('protestId') protestId: string,
     @Body() body: Omit<ReviewProtestCommandDTO, 'protestId'>,
   ): Promise<void> {
-    const presenter = await this.protestsService.reviewProtest({ protestId, ...body });
-    const viewModel = presenter.viewModel;
+    const result: ReviewProtestResponseDTO = await this.protestsService.reviewProtest({ protestId, ...body });
 
-    if (!viewModel.success) {
-      switch (viewModel.errorCode) {
+    if (!result.success) {
+      switch (result.errorCode) {
         case 'PROTEST_NOT_FOUND':
-          throw new NotFoundException(viewModel.message ?? 'Protest not found');
+          throw new NotFoundException(result.message ?? 'Protest not found');
         case 'RACE_NOT_FOUND':
-          throw new NotFoundException(viewModel.message ?? 'Race not found for protest');
+          throw new NotFoundException(result.message ?? 'Race not found for protest');
         case 'NOT_LEAGUE_ADMIN':
-          throw new ForbiddenException(viewModel.message ?? 'Steward is not authorized to review this protest');
+          throw new ForbiddenException(result.message ?? 'Steward is not authorized to review this protest');
         default:
-          throw new InternalServerErrorException(viewModel.message ?? 'Failed to review protest');
+          throw new InternalServerErrorException(result.message ?? 'Failed to review protest');
       }
     }
   }