website refactor

apps/website/eslint-rules/view-data-builder-contract.js

@@ -1,10 +1,10 @@
 /**
  * ESLint rule to enforce View Data Builder contract
- * 
+ *
  * View Data Builders must:
  * 1. Be classes named *ViewDataBuilder
  * 2. Have a static build() method
- * 3. Accept an API DTO as parameter
+ * 3. Accept API DTO as parameter (named 'apiDto', NOT 'pageDto')
  * 4. Return View Data
  */
 
@@ -22,6 +22,7 @@ module.exports = {
       notAClass: 'View Data Builders must be classes named *ViewDataBuilder',
       missingBuildMethod: 'View Data Builders must have a static build() method',
       invalidBuildSignature: 'build() method must accept API DTO and return View Data',
+      wrongParameterName: 'Parameter must be named "apiDto", not "pageDto" or other names',
     },
   },
 
@@ -33,6 +34,7 @@ module.exports = {
 
     let hasBuildMethod = false;
     let hasCorrectSignature = false;
+    let hasCorrectParameterName = false;
 
     return {
       // Check class declaration
@@ -47,7 +49,7 @@ module.exports = {
         }
 
         // Check for static build method
-        const buildMethod = node.body.body.find(member => 
+        const buildMethod = node.body.body.find(member =>
           member.type === 'MethodDefinition' &&
           member.key.type === 'Identifier' &&
           member.key.name === 'build' &&
@@ -58,10 +60,22 @@ module.exports = {
           hasBuildMethod = true;
           
           // Check signature - should have at least one parameter
-          if (buildMethod.value && 
-              buildMethod.value.params && 
+          if (buildMethod.value &&
+              buildMethod.value.params &&
               buildMethod.value.params.length > 0) {
             hasCorrectSignature = true;
+            
+            // Check parameter name
+            const firstParam = buildMethod.value.params[0];
+            if (firstParam.type === 'Identifier' && firstParam.name === 'apiDto') {
+              hasCorrectParameterName = true;
+            } else if (firstParam.type === 'Identifier' && firstParam.name === 'pageDto') {
+              // Report specific error for pageDto
+              context.report({
+                node: firstParam,
+                messageId: 'wrongParameterName',
+              });
+            }
           }
         }
       },
@@ -77,6 +91,12 @@ module.exports = {
             node: context.getSourceCode().ast,
             messageId: 'invalidBuildSignature',
           });
+        } else if (!hasCorrectParameterName) {
+          // Only report if not already reported for pageDto
+          context.report({
+            node: context.getSourceCode().ast,
+            messageId: 'wrongParameterName',
+          });
         }
       },
     };