website refactor

core/racing/application/use-cases/GetLeagueAdminPermissionsUseCase.test.ts

@@ -1,18 +1,15 @@
-import { describe, it, expect, beforeEach, vi, type Mock } from 'vitest';
-import {
-  GetLeagueAdminPermissionsUseCase,
-  type GetLeagueAdminPermissionsInput,
-  type GetLeagueAdminPermissionsResult,
-  type GetLeagueAdminPermissionsErrorCode,
-} from './GetLeagueAdminPermissionsUseCase';
-import type { LeagueRepository } from '../../domain/repositories/LeagueRepository';
-import type { LeagueMembershipRepository } from '../../domain/repositories/LeagueMembershipRepository';
+import type { Logger } from '@core/shared/domain/Logger';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
-import type { Logger } from '@core/shared/application';
+import { beforeEach, describe, expect, it, vi, type Mock } from 'vitest';
+import {
+    GetLeagueAdminPermissionsUseCase,
+    type GetLeagueAdminPermissionsErrorCode,
+    type GetLeagueAdminPermissionsInput
+} from './GetLeagueAdminPermissionsUseCase';
 
 describe('GetLeagueAdminPermissionsUseCase', () => {
-  let mockLeagueRepo: ILeagueRepository;
-  let mockMembershipRepo: ILeagueMembershipRepository;
+  let mockLeagueRepo: any;
+  let mockMembershipRepo: any;
   let mockFindById: Mock;
   let mockGetMembership: Mock;
   const logger: Logger = {
@@ -34,7 +31,7 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
       exists: vi.fn(),
       findByOwnerId: vi.fn(),
       searchByName: vi.fn(),
-    } as ILeagueRepository;
+    };
 
     mockMembershipRepo = {
       getMembership: mockGetMembership,
@@ -46,9 +43,8 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
       removeJoinRequest: vi.fn(),
       countByLeagueId: vi.fn(),
       getLeagueMembers: vi.fn(),
-    } as ILeagueMembershipRepository;
-
-    });
+    };
+  });
 
   const createUseCase = () => new GetLeagueAdminPermissionsUseCase(mockLeagueRepo,
     mockMembershipRepo,
@@ -59,7 +55,7 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     performerDriverId: 'driver1',
   };
 
-  it('returns LEAGUE_NOT_FOUND when league does not exist and does not call output', async () => {
+  it('returns LEAGUE_NOT_FOUND when league does not exist', async () => {
     mockFindById.mockResolvedValue(null);
 
     const useCase = createUseCase();
@@ -69,9 +65,9 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     const err = result.unwrapErr() as ApplicationErrorCode<GetLeagueAdminPermissionsErrorCode, { message: string }>;
     expect(err.code).toBe('LEAGUE_NOT_FOUND');
     expect(err.details.message).toBe('League not found');
-    });
+  });
 
-  it('returns USER_NOT_MEMBER when membership is missing and does not call output', async () => {
+  it('returns USER_NOT_MEMBER when membership is missing', async () => {
     mockFindById.mockResolvedValue({ id: 'league1' });
     mockGetMembership.mockResolvedValue(null);
 
@@ -82,9 +78,9 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     const err = result.unwrapErr() as ApplicationErrorCode<GetLeagueAdminPermissionsErrorCode, { message: string }>;
     expect(err.code).toBe('USER_NOT_MEMBER');
     expect(err.details.message).toBe('User is not a member of this league');
-    });
+  });
 
-  it('returns USER_NOT_MEMBER when membership is not active and does not call output', async () => {
+  it('returns USER_NOT_MEMBER when membership is not active', async () => {
     mockFindById.mockResolvedValue({ id: 'league1' });
     mockGetMembership.mockResolvedValue({ status: 'inactive', role: 'admin' });
 
@@ -95,9 +91,9 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     const err = result.unwrapErr() as ApplicationErrorCode<GetLeagueAdminPermissionsErrorCode, { message: string }>;
     expect(err.code).toBe('USER_NOT_MEMBER');
     expect(err.details.message).toBe('User is not a member of this league');
-    });
+  });
 
-  it('returns USER_NOT_MEMBER when role is member and does not call output', async () => {
+  it('returns USER_NOT_MEMBER when role is member', async () => {
     mockFindById.mockResolvedValue({ id: 'league1' });
     mockGetMembership.mockResolvedValue({ status: 'active', role: 'member' });
 
@@ -108,10 +104,10 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     const err = result.unwrapErr() as ApplicationErrorCode<GetLeagueAdminPermissionsErrorCode, { message: string }>;
     expect(err.code).toBe('USER_NOT_MEMBER');
     expect(err.details.message).toBe('User is not a member of this league');
-    });
+  });
 
-  it('returns admin permissions for admin role and calls output once', async () => {
-    const league = { id: 'league1' } as unknown as { id: string };
+  it('returns admin permissions for admin role', async () => {
+    const league = { id: 'league1' } as any;
     mockFindById.mockResolvedValue(league);
     mockGetMembership.mockResolvedValue({ status: 'active', role: 'admin' });
 
@@ -119,9 +115,9 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBeUndefined();
+    const presented = result.unwrap();
 
-    const presented = expect(presented.league).toBe(league);
+    expect(presented.league).toBe(league);
     expect(presented.permissions).toEqual({
       canManageSchedule: true,
       canManageMembers: true,
@@ -130,8 +126,8 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     });
   });
 
-  it('returns admin permissions for owner role and calls output once', async () => {
-    const league = { id: 'league1' } as unknown as { id: string };
+  it('returns admin permissions for owner role', async () => {
+    const league = { id: 'league1' } as any;
     mockFindById.mockResolvedValue(league);
     mockGetMembership.mockResolvedValue({ status: 'active', role: 'owner' });
 
@@ -139,9 +135,9 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     const result = await useCase.execute(input);
 
     expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBeUndefined();
+    const presented = result.unwrap();
 
-    const presented = expect(presented.league).toBe(league);
+    expect(presented.league).toBe(league);
     expect(presented.permissions).toEqual({
       canManageSchedule: true,
       canManageMembers: true,
@@ -150,7 +146,7 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     });
   });
 
-  it('wraps repository errors in REPOSITORY_ERROR and does not call output', async () => {
+  it('wraps repository errors in REPOSITORY_ERROR', async () => {
     const error = new Error('repo failed');
     mockFindById.mockRejectedValue(error);
 
@@ -161,5 +157,5 @@ describe('GetLeagueAdminPermissionsUseCase', () => {
     const err = result.unwrapErr() as ApplicationErrorCode<GetLeagueAdminPermissionsErrorCode, { message: string }>;
     expect(err.code).toBe('REPOSITORY_ERROR');
     expect(err.details.message).toBe('repo failed');
-    });
+  });
 });