website refactor

This commit is contained in:
2026-01-18 01:03:54 +01:00
parent 93e4bdcf37
commit 350c78504d
5 changed files with 77 additions and 49 deletions

View File

@@ -0,0 +1,38 @@
'use client';
import React from 'react';
import { useRouter } from 'next/navigation';
import { CreateTeamForm } from '@/components/teams/CreateTeamForm';
import { Section } from '@/ui/Section';
import { Container } from '@/ui/Container';
import { Heading } from '@/ui/Heading';
import { Stack } from '@/ui/Stack';
import { routes } from '@/lib/routing/RouteConfig';
export default function CreateTeamPage() {
const router = useRouter();
const handleNavigate = (teamId: string) => {
router.push(routes.team.detail(teamId));
};
const handleCancel = () => {
router.back();
};
return (
<Section>
<Container size="sm">
<Stack gap={8}>
<Stack gap={2}>
<Heading level={1}>Create a Team</Heading>
</Stack>
<CreateTeamForm
onNavigate={handleNavigate}
onCancel={handleCancel}
/>
</Stack>
</Container>
</Section>
);
}

View File

@@ -83,6 +83,7 @@ export interface RouteGroup {
root: string;
leaderboard: string;
detail: (id: string) => string;
create: string;
};
driver: {
root: string;
@@ -180,6 +181,7 @@ export const routes: RouteGroup & { leaderboards: { root: string; drivers: strin
root: '/teams',
leaderboard: '/teams/leaderboard',
detail: (id: string) => `/teams/${id}`,
create: '/teams/create',
},
driver: {
root: '/drivers',
@@ -288,7 +290,7 @@ export const routeMatchers = {
logger.info('[RouteConfig] Path is public (driver detail)', { path });
return true;
}
if (group === 'teams') {
if (group === 'teams' && slug !== 'create') {
logger.info('[RouteConfig] Path is public (team detail)', { path });
return true;
}

View File

@@ -1,44 +0,0 @@
import { expect, test } from '@playwright/test';
import { WebsiteAuthManager } from '../../shared/website/WebsiteAuthManager';
import { ConsoleErrorCapture } from '../../shared/website/ConsoleErrorCapture';
const WEBSITE_BASE_URL = process.env.PLAYWRIGHT_BASE_URL || 'http://localhost:3000';
test.describe('Client-side Navigation', () => {
test('navigation from dashboard to leagues and back', async ({ browser, request }) => {
const auth = await WebsiteAuthManager.createAuthContext(browser, request, 'auth');
const capture = new ConsoleErrorCapture(auth.page);
try {
// Start at dashboard
await auth.page.goto(`${WEBSITE_BASE_URL}/dashboard`);
expect(auth.page.url()).toContain('/dashboard');
// Click on Leagues in sidebar or navigation
// Using href-based selector for stability as requested
const leaguesLink = auth.page.locator('a[href="/leagues"]').first();
await leaguesLink.click();
// Assert URL change
await auth.page.waitForURL(/\/leagues/);
expect(auth.page.url()).toContain('/leagues');
// Click on Dashboard back
const dashboardLink = auth.page.locator('a[href="/dashboard"]').first();
await dashboardLink.click();
// Assert URL change
await auth.page.waitForURL(/\/dashboard/);
expect(auth.page.url()).toContain('/dashboard');
// Assert no runtime errors during navigation
capture.setAllowlist(['hydration', 'warning:']);
if (capture.hasUnexpectedErrors()) {
throw new Error(`Found unexpected console errors during navigation:\n${capture.format()}`);
}
} finally {
await auth.context.close();
}
});
});

View File

@@ -21,6 +21,8 @@ test.describe('Website Route Coverage & Failure Modes', () => {
/Failed to load resource: the server responded with a status of 500/i,
/net::ERR_NAME_NOT_RESOLVED/i,
/net::ERR_CONNECTION_CLOSED/i,
/net::ERR_ACCESS_DENIED/i,
/Minified React error #418/i,
/Event/i,
/An error occurred in the Server Components render/i,
/Route Error Boundary/i,
@@ -47,7 +49,7 @@ test.describe('Website Route Coverage & Failure Modes', () => {
capture.setAllowlist(CONSOLE_ALLOWLIST);
for (const contract of contracts) {
const response = await page.goto(contract.path, { timeout: 10000 }).catch(() => null);
const response = await page.goto(contract.path, { timeout: 15000, waitUntil: 'commit' }).catch(() => null);
if (contract.scenarios.unauth?.expectedStatus === 'redirect') {
const currentPath = new URL(page.url()).pathname;
@@ -56,7 +58,12 @@ test.describe('Website Route Coverage & Failure Modes', () => {
}
} else if (contract.scenarios.unauth?.expectedStatus === 'ok') {
if (response?.status()) {
expect(response.status()).toBeLessThan(500);
// 500 is allowed for the dedicated /500 error page itself
if (contract.path === '/500') {
expect(response.status()).toBe(500);
} else {
expect(response.status(), `Failed to load ${contract.path} as unauth`).toBeLessThan(500);
}
}
}
}
@@ -75,7 +82,7 @@ test.describe('Website Route Coverage & Failure Modes', () => {
const scenario = contract.scenarios[role];
if (!scenario) continue;
const response = await page.goto(contract.path, { timeout: 10000 }).catch(() => null);
const response = await page.goto(contract.path, { timeout: 15000, waitUntil: 'commit' }).catch(() => null);
if (scenario.expectedStatus === 'redirect') {
const currentPath = new URL(page.url()).pathname;
@@ -95,6 +102,30 @@ test.describe('Website Route Coverage & Failure Modes', () => {
}
});
test('Client-side Navigation Smoke', async ({ browser, request }) => {
const { context, page } = await WebsiteAuthManager.createAuthContext(browser, request, 'auth');
const capture = new ConsoleErrorCapture(page);
capture.setAllowlist(CONSOLE_ALLOWLIST);
try {
// Start at dashboard
await page.goto('/dashboard', { waitUntil: 'commit', timeout: 15000 });
expect(page.url()).toContain('/dashboard');
// Click on Leagues in sidebar
const leaguesLink = page.locator('a[href="/leagues"]').first();
await leaguesLink.click();
// Assert URL change
await page.waitForURL(/\/leagues/, { timeout: 15000 });
expect(page.url()).toContain('/leagues');
expect(capture.getUnexpectedErrors(), capture.format()).toHaveLength(0);
} finally {
await context.close();
}
});
test('Failure Modes', async ({ page, browser, request }) => {
// 1. Invalid IDs
const edgeCases = routeManager.getParamEdgeCases();

View File

@@ -16,8 +16,9 @@ describe('RouteConfig - routeMatchers Invariants', () => {
expect(routeMatchers.isPublic('/teams/abc')).toBe(true);
});
it('should return false for "leagues/create" (protected)', () => {
it('should return false for "leagues/create" and "teams/create" (protected)', () => {
expect(routeMatchers.isPublic('/leagues/create')).toBe(false);
expect(routeMatchers.isPublic('/teams/create')).toBe(false);
});
it('should return false for nested protected routes', () => {