fix issues in core
This commit is contained in:
@@ -3,13 +3,11 @@ import {
|
||||
CompleteDriverOnboardingUseCase,
|
||||
type CompleteDriverOnboardingInput,
|
||||
type CompleteDriverOnboardingResult,
|
||||
type CompleteDriverOnboardingApplicationError,
|
||||
} from './CompleteDriverOnboardingUseCase';
|
||||
import type { IDriverRepository } from '../../domain/repositories/IDriverRepository';
|
||||
import { Driver } from '../../domain/entities/Driver';
|
||||
import type { UseCaseOutputPort } from '@core/shared/application/UseCaseOutputPort';
|
||||
import type { Logger } from '@core/shared/application/Logger';
|
||||
import type { Result } from '@core/shared/application/Result';
|
||||
|
||||
describe('CompleteDriverOnboardingUseCase', () => {
|
||||
let useCase: CompleteDriverOnboardingUseCase;
|
||||
@@ -35,7 +33,6 @@ describe('CompleteDriverOnboardingUseCase', () => {
|
||||
useCase = new CompleteDriverOnboardingUseCase(
|
||||
driverRepository as unknown as IDriverRepository,
|
||||
logger,
|
||||
output,
|
||||
);
|
||||
});
|
||||
|
||||
@@ -62,9 +59,7 @@ describe('CompleteDriverOnboardingUseCase', () => {
|
||||
const result = await useCase.execute(command);
|
||||
|
||||
expect(result.isOk()).toBe(true);
|
||||
expect(result.unwrap()).toBeUndefined();
|
||||
expect(output.present).toHaveBeenCalledTimes(1);
|
||||
expect(output.present).toHaveBeenCalledWith({ driver: createdDriver });
|
||||
expect(result.unwrap()).toEqual({ driver: createdDriver });
|
||||
expect(driverRepository.findById).toHaveBeenCalledWith('user-1');
|
||||
expect(driverRepository.create).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
@@ -99,7 +94,6 @@ describe('CompleteDriverOnboardingUseCase', () => {
|
||||
expect(result.isErr()).toBe(true);
|
||||
expect(result.unwrapErr().code).toBe('DRIVER_ALREADY_EXISTS');
|
||||
expect(driverRepository.create).not.toHaveBeenCalled();
|
||||
expect(output.present).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should return error when repository create throws', async () => {
|
||||
@@ -120,7 +114,6 @@ describe('CompleteDriverOnboardingUseCase', () => {
|
||||
const error = result.unwrapErr() as { code: 'REPOSITORY_ERROR'; details?: { message: string } };
|
||||
expect(error.code).toBe('REPOSITORY_ERROR');
|
||||
expect(error.details?.message).toBe('DB error');
|
||||
expect(output.present).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should handle bio being undefined', async () => {
|
||||
@@ -144,7 +137,7 @@ describe('CompleteDriverOnboardingUseCase', () => {
|
||||
const result = await useCase.execute(command);
|
||||
|
||||
expect(result.isOk()).toBe(true);
|
||||
expect(result.unwrap()).toBeUndefined();
|
||||
expect(result.unwrap()).toEqual({ driver: createdDriver });
|
||||
expect(driverRepository.create).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
id: 'user-1',
|
||||
@@ -154,7 +147,5 @@ describe('CompleteDriverOnboardingUseCase', () => {
|
||||
bio: undefined,
|
||||
})
|
||||
);
|
||||
expect(output.present).toHaveBeenCalledTimes(1);
|
||||
expect(output.present).toHaveBeenCalledWith({ driver: createdDriver });
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user