core tests

core/shared/domain/Entity.ts

@@ -3,7 +3,15 @@ export interface EntityProps<Id = string> {
 }
 
 export abstract class Entity<Id> implements EntityProps<Id> {
-  protected constructor(readonly id: Id) {}
+  protected constructor(readonly id: Id) {
+    // Make the id property truly immutable at runtime
+    Object.defineProperty(this, 'id', {
+      value: id,
+      writable: false,
+      enumerable: true,
+      configurable: false
+    });
+  }
 
   equals(other?: Entity<Id>): boolean {
     return !!other && this.id === other.id;

core/shared/domain/ValueObject.test.ts

@@ -10,6 +10,7 @@ class TestValueObject implements ValueObject<{ name: string; value: number }> {
   }
 
   equals(other: ValueObject<{ name: string; value: number }>): boolean {
+    if (!other) return false;
     return (
       this.props.name === other.props.name && this.props.value === other.props.value
     );