refactor use cases

core/league/application/ports/ILeagueStandingsRepository.ts

@@ -1,16 +0,0 @@
-export interface RawStanding {
-  id: string;
-  leagueId: string;
-  driverId: string;
-  position: number;
-  points: number;
-  wins: number;
-  racesCompleted: number;
-  // These properties might be optional or present depending on the data source
-  seasonId?: string;
-  podiums?: number;
-}
-
-export interface ILeagueStandingsRepository {
-  getLeagueStandings(leagueId: string): Promise<RawStanding[]>;
-}

core/league/application/use-cases/GetLeagueStandingsUseCase.ts

@@ -1,22 +0,0 @@
-// TODO is this even used? either remove or it must be within racing domain
-
-export interface GetLeagueStandingsUseCase {
-  execute(leagueId: string): Promise<LeagueStandingsViewModel>;
-}
-
-export interface StandingItemViewModel {
-  id: string;
-  leagueId: string;
-  seasonId: string;
-  driverId: string;
-  position: number;
-  points: number;
-  wins: number;
-  podiums: number;
-  racesCompleted: number;
-}
-
-export interface LeagueStandingsViewModel {
-  leagueId: string;
-  standings: StandingItemViewModel[];
-}

core/league/application/use-cases/GetLeagueStandingsUseCaseImpl.test.ts

@@ -1,77 +0,0 @@
-import { describe, it, expect, vi, type Mock } from 'vitest';
-import { GetLeagueStandingsUseCaseImpl } from './GetLeagueStandingsUseCaseImpl';
-import type { ILeagueStandingsRepository, RawStanding } from '../ports/ILeagueStandingsRepository';
-
-describe('GetLeagueStandingsUseCaseImpl', () => {
-  let repository: {
-    getLeagueStandings: Mock;
-  };
-  let useCase: GetLeagueStandingsUseCaseImpl;
-
-  beforeEach(() => {
-    repository = {
-      getLeagueStandings: vi.fn(),
-    } as unknown as ILeagueStandingsRepository as any;
-
-    useCase = new GetLeagueStandingsUseCaseImpl(repository as unknown as ILeagueStandingsRepository);
-  });
-
-  it('maps raw standings from repository to view model', async () => {
-    const leagueId = 'league-1';
-    const rawStandings: RawStanding[] = [
-      {
-        id: 's1',
-        leagueId,
-        seasonId: 'season-1',
-        driverId: 'driver-1',
-        position: 1,
-        points: 100,
-        wins: 3,
-        podiums: 5,
-        racesCompleted: 10,
-      },
-      {
-        id: 's2',
-        leagueId,
-        seasonId: null,
-        driverId: 'driver-2',
-        position: 2,
-        points: 80,
-        wins: 1,
-        podiums: null,
-        racesCompleted: 10,
-      },
-    ];
-
-    repository.getLeagueStandings.mockResolvedValue(rawStandings);
-
-    const result = await useCase.execute(leagueId);
-
-    expect(repository.getLeagueStandings).toHaveBeenCalledWith(leagueId);
-    expect(result.leagueId).toBe(leagueId);
-    expect(result.standings).toEqual([
-      {
-        id: 's1',
-        leagueId,
-        seasonId: 'season-1',
-        driverId: 'driver-1',
-        position: 1,
-        points: 100,
-        wins: 3,
-        podiums: 5,
-        racesCompleted: 10,
-      },
-      {
-        id: 's2',
-        leagueId,
-        seasonId: '',
-        driverId: 'driver-2',
-        position: 2,
-        points: 80,
-        wins: 1,
-        podiums: 0,
-        racesCompleted: 10,
-      },
-    ]);
-  });
-});

core/league/application/use-cases/GetLeagueStandingsUseCaseImpl.ts

@@ -1,31 +0,0 @@
-import { ILeagueStandingsRepository, RawStanding } from '../ports/ILeagueStandingsRepository';
-import { GetLeagueStandingsUseCase, LeagueStandingsViewModel, StandingItemViewModel } from './GetLeagueStandingsUseCase';
-
-// TODO is this even used? either remove or it must be within racing domain
-
-export class GetLeagueStandingsUseCaseImpl implements GetLeagueStandingsUseCase {
-  constructor(private repository: ILeagueStandingsRepository) {}
-
-  async execute(leagueId: string): Promise<LeagueStandingsViewModel> {
-    const rawStandings = await this.repository.getLeagueStandings(leagueId);
-
-    const standingItems: StandingItemViewModel[] = rawStandings.map((standing: RawStanding) => {
-      return {
-        id: standing.id,
-        leagueId: standing.leagueId,
-        seasonId: standing.seasonId ?? '',
-        driverId: standing.driverId,
-        position: standing.position,
-        points: standing.points,
-        wins: standing.wins,
-        podiums: standing.podiums ?? 0,
-        racesCompleted: standing.racesCompleted,
-      };
-    });
-
-    return {
-      leagueId: leagueId,
-      standings: standingItems,
-    };
-  }
-}

core/notifications/application/use-cases/NotificationPreferencesUseCases.test.ts

@@ -1,28 +1,27 @@
-import { describe, it, expect, vi, type Mock } from 'vitest';
-import {
-  GetNotificationPreferencesQuery,
-  UpdateChannelPreferenceUseCase,
-  UpdateTypePreferenceUseCase,
-  UpdateQuietHoursUseCase,
-  SetDigestModeUseCase,
-  type GetNotificationPreferencesInput,
-  type GetNotificationPreferencesResult,
-  type UpdateChannelPreferenceCommand,
-  type UpdateChannelPreferenceResult,
-  type UpdateTypePreferenceCommand,
-  type UpdateTypePreferenceResult,
-  type UpdateQuietHoursCommand,
-  type UpdateQuietHoursResult,
-  type SetDigestModeCommand,
-  type SetDigestModeResult,
-} from './NotificationPreferencesUseCases';
-import type { INotificationPreferenceRepository } from '../../domain/repositories/INotificationPreferenceRepository';
-import type { NotificationPreference , ChannelPreference, TypePreference } from '../../domain/entities/NotificationPreference';
 import type { Logger, UseCaseOutputPort } from '@core/shared/application';
 import { Result } from '@core/shared/application/Result';
 import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
+import { describe, expect, it, vi, type Mock } from 'vitest';
+import type { ChannelPreference, NotificationPreference, TypePreference } from '../../domain/entities/NotificationPreference';
+import type { INotificationPreferenceRepository } from '../../domain/repositories/INotificationPreferenceRepository';
 import type { NotificationChannel, NotificationType } from '../../domain/types/NotificationTypes';
-import { NotificationDomainError } from '../../domain/errors/NotificationDomainError';
+import {
+  GetNotificationPreferencesQuery,
+  SetDigestModeUseCase,
+  UpdateChannelPreferenceUseCase,
+  UpdateQuietHoursUseCase,
+  UpdateTypePreferenceUseCase,
+  type GetNotificationPreferencesInput,
+  type GetNotificationPreferencesResult,
+  type SetDigestModeCommand,
+  type SetDigestModeResult,
+  type UpdateChannelPreferenceCommand,
+  type UpdateChannelPreferenceResult,
+  type UpdateQuietHoursCommand,
+  type UpdateQuietHoursResult,
+  type UpdateTypePreferenceCommand,
+  type UpdateTypePreferenceResult,
+} from './NotificationPreferencesUseCases';
 
 describe('NotificationPreferencesUseCases', () => {
   let preferenceRepository: {

core/notifications/application/use-cases/SendNotificationUseCase.ts

@@ -81,13 +81,15 @@ export class SendNotificationUseCase {
           ...(command.data ? { data: command.data } : {}),
           ...(command.actionUrl ? { actionUrl: command.actionUrl } : {}),
         });
-  
+
         await this.notificationRepository.create(notification);
-  
-        return {
+
+        this.output.present({
           notification,
           deliveryResults: [],
-        };
+        });
+
+        return Result.ok(undefined);
       }
   
       // Determine which channels to use

core/racing/index.ts

@@ -40,11 +40,7 @@ export * from './domain/repositories/ISponsorshipPricingRepository';
 
 export * from './application/dtos/LeagueDriverSeasonStatsDTO';
 export * from './application/dtos/LeagueScoringConfigDTO';
-
-export * from './application/ports/output/CreateLeagueWithSeasonAndScoringOutputPort';
-export * from './application/ports/output/DashboardOverviewOutputPort';
-export * from './application/ports/output/DriversLeaderboardOutputPort';
-
+ 
 export * from './application/use-cases/CreateSponsorUseCase';
 export * from './application/use-cases/GetSponsorDashboardUseCase';
 export * from './application/use-cases/GetSponsorSponsorshipsUseCase';
@@ -53,5 +49,3 @@ export * from './application/use-cases/AcceptSponsorshipRequestUseCase';
 export * from './application/use-cases/RejectSponsorshipRequestUseCase';
 export * from './application/use-cases/GetPendingSponsorshipRequestsUseCase';
 export * from './application/use-cases/GetEntitySponsorshipPricingUseCase';
-
-export * from './application/ports/output/CreateSponsorOutputPort';

core/social/application/use-cases/GetCurrentUserSocialUseCase.ts

@@ -1,43 +1,65 @@
-import type { AsyncUseCase , Logger } from '@core/shared/application';
+import type { Logger , UseCaseOutputPort } from '@core/shared/application';
+import { Result } from '@core/shared/application/Result';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import type { ISocialGraphRepository } from '../../domain/repositories/ISocialGraphRepository';
 import type { CurrentUserSocialDTO } from '../dto/CurrentUserSocialDTO';
 import type { FriendDTO } from '../dto/FriendDTO';
-import type {
-  CurrentUserSocialViewModel,
-  ICurrentUserSocialPresenter,
-} from '../presenters/ISocialPresenters';
 
 export interface GetCurrentUserSocialParams {
   driverId: string;
 }
 
+export type GetCurrentUserSocialInput = GetCurrentUserSocialParams;
+
+export interface GetCurrentUserSocialResult {
+  currentUser: CurrentUserSocialDTO;
+  friends: FriendDTO[];
+}
+
+export type GetCurrentUserSocialErrorCode = 'REPOSITORY_ERROR';
+
+export type GetCurrentUserSocialApplicationError = ApplicationErrorCode<
+  GetCurrentUserSocialErrorCode,
+  { message: string }
+>;
+
 /**
  * Application-level use case to retrieve the current user's social context.
  *
  * Keeps orchestration in the social bounded context while delegating
- * data access to domain repositories and presenting via a presenter.
+ * data access to domain repositories and presenting via an output port.
  */
-export class GetCurrentUserSocialUseCase
-  implements AsyncUseCase<GetCurrentUserSocialParams, void> {
+export class GetCurrentUserSocialUseCase {
   constructor(
     private readonly socialGraphRepository: ISocialGraphRepository,
-    public readonly presenter: ICurrentUserSocialPresenter,
     private readonly logger: Logger,
+    private readonly output: UseCaseOutputPort<GetCurrentUserSocialResult>,
   ) {}
 
-  async execute(params: GetCurrentUserSocialParams): Promise<void> {
-    this.logger.debug('GetCurrentUserSocialUseCase: Starting execution', { params });
-    try {
-      const { driverId } = params;
+  async execute(
+    input: GetCurrentUserSocialInput,
+  ): Promise<Result<void, GetCurrentUserSocialApplicationError>> {
+    this.logger.debug('GetCurrentUserSocialUseCase.execute: Starting execution', { input });
 
-      this.logger.debug(`GetCurrentUserSocialUseCase: Fetching friends for driverId: ${driverId}`);
+    try {
+      const { driverId } = input;
+
+      this.logger.debug(
+        'GetCurrentUserSocialUseCase.execute: Fetching friends for driverId',
+        { driverId },
+      );
       const friendsDomain = await this.socialGraphRepository.getFriends(driverId);
-      this.logger.debug('GetCurrentUserSocialUseCase: Successfully fetched friends from social graph repository', { friendsCount: friendsDomain.length });
+      this.logger.debug(
+        'GetCurrentUserSocialUseCase.execute: Successfully fetched friends from social graph repository',
+        { friendsCount: friendsDomain.length },
+      );
       if (friendsDomain.length === 0) {
-        this.logger.warn(`GetCurrentUserSocialUseCase: No friends found for driverId: ${driverId}`);
+        this.logger.warn(
+          `GetCurrentUserSocialUseCase.execute: No friends found for driverId: ${driverId}`,
+        );
       }
 
-      const friends: FriendDTO[] = friendsDomain.map((friend) => ({
+      const friends: FriendDTO[] = friendsDomain.map(friend => ({
         driverId: friend.id,
         displayName: friend.name,
         avatarUrl: '',
@@ -52,16 +74,32 @@ export class GetCurrentUserSocialUseCase
         countryCode: '',
       };
 
-      const viewModel: CurrentUserSocialViewModel = {
+      const result: GetCurrentUserSocialResult = {
         currentUser,
         friends,
       };
 
-      this.presenter.present(viewModel);
-      this.logger.info('GetCurrentUserSocialUseCase: Successfully presented current user social data');
+      this.output.present(result);
+      this.logger.info(
+        'GetCurrentUserSocialUseCase.execute: Successfully presented current user social data',
+      );
+
+      return Result.ok(undefined);
     } catch (error) {
-      this.logger.error('GetCurrentUserSocialUseCase: Error during execution', { error });
-      throw error;
+      const err = error instanceof Error ? error : new Error(String(error));
+
+      this.logger.error(
+        'GetCurrentUserSocialUseCase.execute: Error during execution',
+        err,
+        { input },
+      );
+
+      return Result.err({
+        code: 'REPOSITORY_ERROR',
+        details: {
+          message: err.message,
+        },
+      } as GetCurrentUserSocialApplicationError);
     }
   }
 }

core/social/application/use-cases/GetUserFeedUseCase.ts

@@ -1,71 +1,74 @@
-import type { AsyncUseCase , Logger } from '@core/shared/application';
+import type { Logger , UseCaseOutputPort } from '@core/shared/application';
+import { Result } from '@core/shared/application/Result';
+import type { ApplicationErrorCode } from '@core/shared/errors/ApplicationErrorCode';
 import type { IFeedRepository } from '../../domain/repositories/IFeedRepository';
-import type { FeedItemDTO } from '../dto/FeedItemDTO';
 import type { FeedItem } from '../../domain/types/FeedItem';
-import type {
-  IUserFeedPresenter,
-  UserFeedViewModel,
-} from '../presenters/ISocialPresenters';
 
 export interface GetUserFeedParams {
   driverId: string;
   limit?: number;
 }
 
-export class GetUserFeedUseCase
-  implements AsyncUseCase<GetUserFeedParams, void> {
+export type GetUserFeedInput = GetUserFeedParams;
+
+export interface GetUserFeedResult {
+  items: FeedItem[];
+}
+
+export type GetUserFeedErrorCode = 'REPOSITORY_ERROR';
+
+export type GetUserFeedApplicationError = ApplicationErrorCode<
+  GetUserFeedErrorCode,
+  { message: string }
+>;
+
+export class GetUserFeedUseCase {
   constructor(
     private readonly feedRepository: IFeedRepository,
-    public readonly presenter: IUserFeedPresenter,
     private readonly logger: Logger,
+    private readonly output: UseCaseOutputPort<GetUserFeedResult>,
   ) {}
 
-  async execute(params: GetUserFeedParams): Promise<void> {
-    const { driverId, limit } = params;
-    this.logger.debug('Executing GetUserFeedUseCase', { driverId, limit });
+  async execute(
+    input: GetUserFeedInput,
+  ): Promise<Result<void, GetUserFeedApplicationError>> {
+    const { driverId, limit } = input;
+    this.logger.debug('GetUserFeedUseCase.execute started', { driverId, limit });
 
     try {
       const items = await this.feedRepository.getFeedForDriver(driverId, limit);
-      this.logger.info('Successfully retrieved user feed', { driverId, itemCount: items.length });
+
+      this.logger.info('GetUserFeedUseCase.execute succeeded', {
+        driverId,
+        itemCount: items.length,
+      });
+
       if (items.length === 0) {
         this.logger.warn(`No feed items found for driverId: ${driverId}`);
       }
-      const dtoItems = items.map(mapFeedItemToDTO);
 
-      const viewModel: UserFeedViewModel = {
-        items: dtoItems,
+      const result: GetUserFeedResult = {
+        items,
       };
 
-      this.presenter.present(viewModel);
+      this.output.present(result);
+
+      return Result.ok(undefined);
     } catch (error) {
-      this.logger.error('Failed to retrieve user feed', error);
-      throw error; // Re-throw the error so it can be handled upstream
+      const err = error instanceof Error ? error : new Error(String(error));
+
+      this.logger.error(
+        'GetUserFeedUseCase.execute failed',
+        err,
+        { input },
+      );
+
+      return Result.err({
+        code: 'REPOSITORY_ERROR',
+        details: {
+          message: err.message,
+        },
+      } as GetUserFeedApplicationError);
     }
   }
-}
-
-function mapFeedItemToDTO(item: FeedItem): FeedItemDTO {
-  const mappedType = (item.type as string).replace(/-/g, '_') as FeedItemDTO['type'];
-
-  const dto: FeedItemDTO = {
-    id: item.id,
-    timestamp:
-      item.timestamp instanceof Date
-        ? item.timestamp.toISOString()
-        : new Date(item.timestamp).toISOString(),
-    type: mappedType,
-    headline: item.headline,
-  };
-
-  if (item.actorFriendId !== undefined) dto.actorFriendId = item.actorFriendId;
-  if (item.actorDriverId !== undefined) dto.actorDriverId = item.actorDriverId;
-  if (item.leagueId !== undefined) dto.leagueId = item.leagueId;
-  if (item.raceId !== undefined) dto.raceId = item.raceId;
-  if (item.teamId !== undefined) dto.teamId = item.teamId;
-  if (item.position !== undefined) dto.position = item.position;
-  if (item.body !== undefined) dto.body = item.body;
-  if (item.ctaLabel !== undefined) dto.ctaLabel = item.ctaLabel;
-  if (item.ctaHref !== undefined) dto.ctaHref = item.ctaHref;
-
-  return dto;
 }