resolve todos in website

apps/website/components/leagues/LeagueHeader.test.tsx

@@ -0,0 +1,41 @@
+import React from 'react';
+import { describe, it, expect } from 'vitest';
+import { render, screen } from '@testing-library/react';
+
+import LeagueHeader from './LeagueHeader';
+
+describe('LeagueHeader', () => {
+  it('renders league name, description and sponsor', () => {
+    render(
+      <LeagueHeader
+        leagueId="league-1"
+        leagueName="Test League"
+        description="A fun test league"
+        ownerId="owner-1"
+        ownerName="Owner Name"
+        mainSponsor={{
+          name: 'Test Sponsor',
+          websiteUrl: 'https://example.com',
+        }}
+      />
+    );
+
+    expect(screen.getByText('Test League')).toBeInTheDocument();
+    expect(screen.getByText('A fun test league')).toBeInTheDocument();
+    expect(screen.getByText('by')).toBeInTheDocument();
+    expect(screen.getByText('Test Sponsor')).toBeInTheDocument();
+  });
+
+  it('renders without description or sponsor', () => {
+    render(
+      <LeagueHeader
+        leagueId="league-2"
+        leagueName="League Without Details"
+        ownerId="owner-2"
+        ownerName="Owner 2"
+      />
+    );
+
+    expect(screen.getByText('League Without Details')).toBeInTheDocument();
+  });
+});

apps/website/components/leagues/LeagueHeader.tsx

@@ -2,12 +2,7 @@
 
 import MembershipStatus from '@/components/leagues/MembershipStatus';
 import Image from 'next/image';
-import { useEffect, useState } from 'react';
 
-import type { DriverDTO } from '@core/racing/application/dto/DriverDTO';
-import { EntityMappers } from '@core/racing/application/mappers/EntityMappers';
-
-// TODO EntityMapper is legacy. Must use ´useServices` hook.
 
 // Main sponsor info for "by XYZ" display
 interface MainSponsorInfo {
@@ -35,30 +30,6 @@ export default function LeagueHeader({
   const imageService = getImageService();
   const logoUrl = imageService.getLeagueLogo(leagueId);
 
-  const [ownerDriver, setOwnerDriver] = useState<DriverDTO | null>(null);
-
-  useEffect(() => {
-    let isMounted = true;
-
-    async function loadOwner() {
-      try {
-        const driverRepo = getDriverRepository();
-        const entity = await driverRepo.findById(ownerId);
-        if (!entity || !isMounted) return;
-        setOwnerDriver(EntityMappers.toDriverDTO(entity));
-      } catch (err) {
-        console.error('Failed to load league owner for header:', err);
-      }
-    }
-
-    loadOwner();
-
-    return () => {
-      isMounted = false;
-    };
-  }, [ownerId]);
-
-
   return (
     <div className="mb-8">
       {/* League header with logo - no cover image */}

apps/website/components/leagues/LeagueMembers.test.tsx

@@ -0,0 +1,129 @@
+import React from 'react';
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { render, screen, waitFor } from '@testing-library/react';
+
+import LeagueMembers from './LeagueMembers';
+import type { DriverDTO } from '@/lib/types/generated/DriverDTO';
+
+// Stub global driver stats helper used by LeagueMembers sorting/rendering
+(globalThis as any).getDriverStats = (driverId: string) => ({
+  driverId,
+  rating: driverId === 'driver-1' ? 2500 : 2000,
+  overallRank: driverId === 'driver-1' ? 1 : 2,
+  wins: driverId === 'driver-1' ? 10 : 5,
+});
+
+// Mock effective driver id so we can assert the "(You)" label
+vi.mock('@/hooks/useEffectiveDriverId', () => {
+  return {
+    useEffectiveDriverId: () => 'driver-1',
+  };
+});
+
+// Mock services hook to inject stub leagueMembershipService and driverService
+const mockFetchLeagueMemberships = vi.fn<[], Promise<any[]>>();
+const mockGetLeagueMembers = vi.fn<(leagueId: string) => any[]>();
+const mockFindByIds = vi.fn<(ids: string[]) => Promise<DriverDTO[]>>();
+
+vi.mock('@/lib/services/ServiceProvider', () => {
+  return {
+    useServices: () => ({
+      leagueMembershipService: {
+        fetchLeagueMemberships: mockFetchLeagueMemberships,
+        getLeagueMembers: mockGetLeagueMembers,
+      },
+      driverService: {
+        findByIds: mockFindByIds,
+      },
+    }),
+  };
+});
+
+describe('LeagueMembers', () => {
+  beforeEach(() => {
+    mockFetchLeagueMemberships.mockReset();
+    mockGetLeagueMembers.mockReset();
+    mockFindByIds.mockReset();
+  });
+
+  it('loads memberships via services and renders driver rows', async () => {
+    const leagueId = 'league-1';
+
+    const memberships = [
+      {
+        id: 'm1',
+        leagueId,
+        driverId: 'driver-1',
+        role: 'owner',
+        status: 'active',
+        joinedAt: '2024-01-01T00:00:00.000Z',
+      },
+      {
+        id: 'm2',
+        leagueId,
+        driverId: 'driver-2',
+        role: 'member',
+        status: 'active',
+        joinedAt: '2024-01-02T00:00:00.000Z',
+      },
+    ];
+
+    const drivers: DriverDTO[] = [
+      {
+        id: 'driver-1',
+        iracingId: 'ir-1',
+        name: 'Driver One',
+        country: 'DE',
+      },
+      {
+        id: 'driver-2',
+        iracingId: 'ir-2',
+        name: 'Driver Two',
+        country: 'US',
+      },
+    ];
+
+    mockFetchLeagueMemberships.mockResolvedValue(memberships);
+    mockGetLeagueMembers.mockReturnValue(memberships);
+    mockFindByIds.mockResolvedValue(drivers);
+
+    render(<LeagueMembers leagueId={leagueId} showActions={false} />);
+
+    // Loading state first
+    expect(screen.getByText('Loading members...')).toBeInTheDocument();
+
+    // Wait for data to be rendered
+    await waitFor(() => {
+      expect(screen.queryByText('Loading members...')).not.toBeInTheDocument();
+    });
+
+    // Services should have been called with expected arguments
+    expect(mockFetchLeagueMemberships).toHaveBeenCalledWith(leagueId);
+    expect(mockGetLeagueMembers).toHaveBeenCalledWith(leagueId);
+    expect(mockFindByIds).toHaveBeenCalledTimes(1);
+    expect(mockFindByIds).toHaveBeenCalledWith(['driver-1', 'driver-2']);
+
+    // Driver rows should be rendered using DTO names
+    expect(screen.getByText('Driver One')).toBeInTheDocument();
+    expect(screen.getByText('Driver Two')).toBeInTheDocument();
+
+    // Current user marker should appear for effective driver id
+    expect(screen.getByText('(You)')).toBeInTheDocument();
+  });
+
+  it('handles empty membership list gracefully', async () => {
+    const leagueId = 'league-empty';
+
+    mockFetchLeagueMemberships.mockResolvedValue([]);
+    mockGetLeagueMembers.mockReturnValue([]);
+    mockFindByIds.mockResolvedValue([]);
+
+    render(<LeagueMembers leagueId={leagueId} showActions={false} />);
+
+    await waitFor(() => {
+      expect(screen.queryByText('Loading members...')).not.toBeInTheDocument();
+    });
+
+    expect(screen.getByText('No members found')).toBeInTheDocument();
+  });
+});

apps/website/components/leagues/LeagueMembers.tsx

@@ -1,17 +1,14 @@
 'use client';
 
-import DriverIdentity from '@/components/drivers/DriverIdentity';
-import { useEffectiveDriverId } from '@/hooks/useEffectiveDriverId';
-import {
-  getLeagueMembers,
-  type LeagueMembership,
-  type MembershipRole,
-} from '@/lib/leagueMembership';
-import type { DriverDTO } from '@core/racing/application/dto/DriverDTO';
-import { EntityMappers } from '@core/racing/application/mappers/EntityMappers';
+import DriverIdentity from '../drivers/DriverIdentity';
+import { useEffectiveDriverId } from '../../hooks/useEffectiveDriverId';
+import { useServices } from '../../lib/services/ServiceProvider';
+import type { LeagueMembership } from '@core/racing/domain/entities/LeagueMembership';
+import type { MembershipRole } from '@core/racing/domain/entities/MembershipRole';
+import type { DriverDTO } from '@/lib/types/generated/DriverDTO';
 import { useCallback, useEffect, useState } from 'react';
 
-// TODO EntityMapper is legacy. Must use ´useServices` hook.
+// Migrated to useServices-based website services; legacy EntityMapper removed.
 
 interface LeagueMembersProps {
   leagueId: string;
@@ -31,32 +28,33 @@ export default function LeagueMembers({
   const [loading, setLoading] = useState(true);
   const [sortBy, setSortBy] = useState<'role' | 'name' | 'date' | 'rating' | 'points' | 'wins'>('rating');
   const currentDriverId = useEffectiveDriverId();
+  const { leagueMembershipService, driverService } = useServices();
 
   const loadMembers = useCallback(async () => {
     setLoading(true);
     try {
-      const membershipData = getLeagueMembers(leagueId);
+      await leagueMembershipService.fetchLeagueMemberships(leagueId);
+      const membershipData = leagueMembershipService.getLeagueMembers(leagueId);
       setMembers(membershipData);
 
-      const driverRepo = getDriverRepository();
-      const driverEntities = await Promise.all(
-        membershipData.map((m) => driverRepo.findById(m.driverId))
-      );
-      const driverDtos = driverEntities
-        .map((driver) => (driver ? EntityMappers.toDriverDTO(driver) : null))
-        .filter((dto): dto is DriverDTO => dto !== null);
+      const uniqueDriverIds = Array.from(new Set(membershipData.map((m) => m.driverId)));
+      if (uniqueDriverIds.length > 0) {
+        const driverDtos = await driverService.findByIds(uniqueDriverIds);
 
-      const byId: Record<string, DriverDTO> = {};
-      for (const dto of driverDtos) {
-        byId[dto.id] = dto;
+        const byId: Record<string, DriverDTO> = {};
+        for (const dto of driverDtos) {
+          byId[dto.id] = dto;
+        }
+        setDriversById(byId);
+      } else {
+        setDriversById({});
       }
-      setDriversById(byId);
     } catch (error) {
       console.error('Failed to load members:', error);
     } finally {
       setLoading(false);
     }
-  }, [leagueId]);
+  }, [leagueId, leagueMembershipService, driverService]);
 
   useEffect(() => {
     loadMembers();