view data fixes
Some checks failed
Contract Testing / contract-tests (pull_request) Failing after 7m11s
Contract Testing / contract-snapshot (pull_request) Has been skipped

This commit is contained in:
2026-01-24 23:29:55 +01:00
parent c1750a33dd
commit 1b0a1f4aee
134 changed files with 10380 additions and 415 deletions

View File

@@ -0,0 +1,154 @@
/* eslint-disable gridpilot-rules/page-query-filename, gridpilot-rules/single-export-per-file, @typescript-eslint/no-explicit-any */
import { describe, it, expect, vi, beforeEach } from 'vitest';
import { TeamDetailPageQuery } from './TeamDetailPageQuery';
import { TeamService } from '@/lib/services/teams/TeamService';
import { Result } from '@/lib/contracts/Result';
import { TeamDetailViewDataBuilder } from '@/lib/builders/view-data/TeamDetailViewDataBuilder';
import { SessionGateway } from '@/lib/gateways/SessionGateway';
import { mapToPresentationError } from '@/lib/contracts/page-queries/PresentationError';
// Mock dependencies
vi.mock('@/lib/services/teams/TeamService', () => ({
TeamService: vi.fn().mockImplementation(function (this: any) {
this.getTeamDetails = vi.fn();
this.getTeamMembers = vi.fn();
}),
}));
vi.mock('@/lib/builders/view-data/TeamDetailViewDataBuilder', () => ({
TeamDetailViewDataBuilder: {
build: vi.fn(),
},
}));
vi.mock('@/lib/gateways/SessionGateway', () => ({
SessionGateway: vi.fn().mockImplementation(function (this: any) {
this.getSession = vi.fn();
}),
}));
vi.mock('@/lib/contracts/page-queries/PresentationError', () => ({
mapToPresentationError: vi.fn(),
}));
describe('TeamDetailPageQuery', () => {
let query: TeamDetailPageQuery;
let mockServiceInstance: any;
let mockSessionGatewayInstance: any;
beforeEach(() => {
vi.clearAllMocks();
query = new TeamDetailPageQuery();
mockServiceInstance = {
getTeamDetails: vi.fn(),
getTeamMembers: vi.fn(),
};
mockSessionGatewayInstance = {
getSession: vi.fn(),
};
(TeamService as any).mockImplementation(function () {
return mockServiceInstance;
});
(SessionGateway as any).mockImplementation(function () {
return mockSessionGatewayInstance;
});
});
it('should return view data when service succeeds', async () => {
const teamId = 'team-123';
const session = { user: { primaryDriverId: 'driver-456' } };
const teamData = { team: { id: teamId, name: 'Test Team', ownerId: 'driver-789' }, membership: null, canManage: false };
const membersData = [{ driverId: 'driver-789', driverName: 'Owner', role: 'owner', joinedAt: '2024-01-01', isActive: true, avatarUrl: 'avatar-url' }];
const viewData = { team: { id: teamId, name: 'Test Team' }, memberships: [], currentDriverId: 'driver-456' };
mockSessionGatewayInstance.getSession.mockResolvedValue(session);
mockServiceInstance.getTeamDetails.mockResolvedValue(Result.ok(teamData));
mockServiceInstance.getTeamMembers.mockResolvedValue(Result.ok(membersData));
(TeamDetailViewDataBuilder.build as any).mockReturnValue(viewData);
const result = await query.execute(teamId);
expect(result.isOk()).toBe(true);
expect(result.unwrap()).toEqual(viewData);
expect(SessionGateway).toHaveBeenCalled();
expect(mockSessionGatewayInstance.getSession).toHaveBeenCalled();
expect(TeamService).toHaveBeenCalled();
expect(mockServiceInstance.getTeamDetails).toHaveBeenCalledWith(teamId, 'driver-456');
expect(mockServiceInstance.getTeamMembers).toHaveBeenCalledWith(teamId, 'driver-456', 'driver-789');
expect(TeamDetailViewDataBuilder.build).toHaveBeenCalled();
});
it('should return view data when session has no primaryDriverId', async () => {
const teamId = 'team-123';
const session = { user: null };
const teamData = { team: { id: teamId, name: 'Test Team', ownerId: 'driver-789' }, membership: null, canManage: false };
const membersData = [{ driverId: 'driver-789', driverName: 'Owner', role: 'owner', joinedAt: '2024-01-01', isActive: true, avatarUrl: 'avatar-url' }];
const viewData = { team: { id: teamId, name: 'Test Team' }, memberships: [], currentDriverId: '' };
mockSessionGatewayInstance.getSession.mockResolvedValue(session);
mockServiceInstance.getTeamDetails.mockResolvedValue(Result.ok(teamData));
mockServiceInstance.getTeamMembers.mockResolvedValue(Result.ok(membersData));
(TeamDetailViewDataBuilder.build as any).mockReturnValue(viewData);
const result = await query.execute(teamId);
expect(result.isOk()).toBe(true);
expect(result.unwrap()).toEqual(viewData);
expect(mockServiceInstance.getTeamDetails).toHaveBeenCalledWith(teamId, '');
expect(mockServiceInstance.getTeamMembers).toHaveBeenCalledWith(teamId, '', 'driver-789');
});
it('should return mapped presentation error when team details fail', async () => {
const teamId = 'team-123';
const session = { user: { primaryDriverId: 'driver-456' } };
const serviceError = { type: 'notFound' };
const presentationError = 'notFound';
mockSessionGatewayInstance.getSession.mockResolvedValue(session);
mockServiceInstance.getTeamDetails.mockResolvedValue(Result.err(serviceError));
(mapToPresentationError as any).mockReturnValue(presentationError);
const result = await query.execute(teamId);
expect(result.isErr()).toBe(true);
expect(result.getError()).toBe(presentationError);
expect(mapToPresentationError).toHaveBeenCalledWith(serviceError);
});
it('should return mapped presentation error when team members fail', async () => {
const teamId = 'team-123';
const session = { user: { primaryDriverId: 'driver-456' } };
const teamData = { team: { id: teamId, name: 'Test Team', ownerId: 'driver-789' }, membership: null, canManage: false };
const serviceError = { type: 'notFound' };
const presentationError = 'notFound';
mockSessionGatewayInstance.getSession.mockResolvedValue(session);
mockServiceInstance.getTeamDetails.mockResolvedValue(Result.ok(teamData));
mockServiceInstance.getTeamMembers.mockResolvedValue(Result.err(serviceError));
(mapToPresentationError as any).mockReturnValue(presentationError);
const result = await query.execute(teamId);
expect(result.isErr()).toBe(true);
expect(result.getError()).toBe(presentationError);
expect(mapToPresentationError).toHaveBeenCalledWith(serviceError);
});
it('should provide a static execute method', async () => {
const teamId = 'team-123';
const session = { user: { primaryDriverId: 'driver-456' } };
const teamData = { team: { id: teamId, name: 'Test Team', ownerId: 'driver-789' }, membership: null, canManage: false };
const membersData = [{ driverId: 'driver-789', driverName: 'Owner', role: 'owner', joinedAt: '2024-01-01', isActive: true, avatarUrl: 'avatar-url' }];
const viewData = { team: { id: teamId, name: 'Test Team' }, memberships: [], currentDriverId: 'driver-456' };
mockSessionGatewayInstance.getSession.mockResolvedValue(session);
mockServiceInstance.getTeamDetails.mockResolvedValue(Result.ok(teamData));
mockServiceInstance.getTeamMembers.mockResolvedValue(Result.ok(membersData));
(TeamDetailViewDataBuilder.build as any).mockReturnValue(viewData);
const result = await TeamDetailPageQuery.execute(teamId);
expect(result.isOk()).toBe(true);
expect(result.unwrap()).toEqual(viewData);
});
});