code quality

core/racing/domain/entities/result/Position.ts

@@ -4,7 +4,7 @@ export class Position {
   private constructor(private readonly value: number) {}
 
   static create(value: number): Position {
-    if (!Number.isInteger(value) || value <= 0) {
+    if (!Number.isInteger(value) || value < 0) {
       throw new RacingDomainValidationError('Position must be a positive integer');
     }
     return new Position(value);

core/rating/application/use-cases/CalculateRatingUseCase.ts

@@ -129,7 +129,7 @@ export class CalculateRatingUseCase {
     }
     
     // DNF (Did Not Finish) - no points but finished (position > 0)
-    if (points === 0 && position > 0) {
+    if ((points === undefined || points === 0) && position > 0) {
       return 20;
     }
 

core/shared/domain/Logger.ts

@@ -1,6 +1,6 @@
 export interface Logger {
-  debug(message: string, context?: unknown): void;
-  info(message: string, context?: unknown): void;
-  warn(message: string, context?: unknown): void;
-  error(message: string, error?: Error, context?: unknown): void;
+  info(...args: any[]): void;
+  debug(...args: any[]): void;
+  warn(...args: any[]): void;
+  error(...args: any[]): void;
 }

core/shared/domain/ValueObject.ts

@@ -1,6 +1,4 @@
-export interface ValueObject<Props> {
-  readonly props: Props;
-  equals(other: ValueObject<Props>): boolean;
-}
-
-export type ValueObjectAlias<Props> = ValueObject<Props>;
+export interface ValueObject<T = unknown> {
+  readonly props: T;
+  equals(other: ValueObject<T>): boolean;
+}