services refactor

apps/website/lib/services/races/RaceResultsService.ts

@@ -1,46 +1,47 @@
-import { api as api } from '../../api';
-import { RaceResultsDetailPresenter, RaceWithSOFPresenter, ImportRaceResultsPresenter } from '../../presenters';
-import { RaceResultsDetailViewModel } from '../../view-models';
+import { RacesApiClient } from '../../api/races/RacesApiClient';
+import { RaceResultsDetailPresenter } from '../../presenters/RaceResultsDetailPresenter';
+import { RaceWithSOFPresenter } from '../../presenters/RaceWithSOFPresenter';
+import type { RaceWithSOFViewModel } from '../../presenters/RaceWithSOFPresenter';
+import { ImportRaceResultsPresenter } from '../../presenters/ImportRaceResultsPresenter';
+import type { ImportRaceResultsSummaryViewModel } from '../../presenters/ImportRaceResultsPresenter';
+import type { RaceResultsDetailViewModel } from '../../view-models/RaceResultsDetailViewModel';
+import type { ImportRaceResultsInputDto } from '../../dtos';
 
+/**
+ * Race Results Service
+ *
+ * Orchestrates race results operations including viewing, importing, and SOF calculations.
+ * All dependencies are injected via constructor.
+ */
 export class RaceResultsService {
   constructor(
-    private readonly apiClient = api.races,
-    private readonly resultsDetailPresenter = new RaceResultsDetailPresenter(),
-    private readonly sofPresenter = new RaceWithSOFPresenter(),
-    private readonly importPresenter = new ImportRaceResultsPresenter()
+    private readonly apiClient: RacesApiClient,
+    private readonly resultsDetailPresenter: RaceResultsDetailPresenter,
+    private readonly sofPresenter: RaceWithSOFPresenter,
+    private readonly importPresenter: ImportRaceResultsPresenter
   ) {}
 
-  async importRaceResults(raceId: string, input: any): Promise<any> {
-    const dto = await this.apiClient.importResults(raceId, input);
-    return this.importPresenter.present(dto);
-  }
-
+  /**
+   * Get race results detail with presentation transformation
+   */
   async getResultsDetail(raceId: string, currentUserId?: string): Promise<RaceResultsDetailViewModel> {
     const dto = await this.apiClient.getResultsDetail(raceId);
     return this.resultsDetailPresenter.present(dto, currentUserId);
   }
 
-  async getWithSOF(raceId: string): Promise<any> {
+  /**
+   * Get race with strength of field calculation
+   */
+  async getWithSOF(raceId: string): Promise<RaceWithSOFViewModel> {
     const dto = await this.apiClient.getWithSOF(raceId);
     return this.sofPresenter.present(dto);
   }
-}
 
-// Singleton instance
-export const raceResultsService = new RaceResultsService();
-
-// Backward compatibility functions
-export async function getRaceResults(
-  raceId: string,
-  currentUserId?: string
-): Promise<RaceResultsDetailViewModel> {
-  return raceResultsService.getResultsDetail(raceId, currentUserId);
-}
-
-export async function getRaceSOF(raceId: string): Promise<any> {
-  return raceResultsService.getWithSOF(raceId);
-}
-
-export async function importRaceResults(raceId: string, input: any): Promise<any> {
-  return raceResultsService.importRaceResults(raceId, input);
+  /**
+   * Import race results and get summary
+   */
+  async importResults(raceId: string, input: ImportRaceResultsInputDto): Promise<ImportRaceResultsSummaryViewModel> {
+    const dto = await this.apiClient.importResults(raceId, input);
+    return this.importPresenter.present(dto);
+  }
 }