services refactor

apps/website/lib/services/drivers/DriverService.ts

@@ -1,43 +1,50 @@
-import { api as api } from '../../api';
-import { presentDriversLeaderboard } from '../../presenters';
-import { DriverLeaderboardViewModel } from '../../view-models';
+import type { DriversApiClient } from '../../api/drivers/DriversApiClient';
+import type { DriversLeaderboardPresenter } from '../../presenters/DriversLeaderboardPresenter';
+import type { DriverPresenter } from '../../presenters/DriverPresenter';
+import type { CompleteOnboardingPresenter } from '../../presenters/CompleteOnboardingPresenter';
+import type { DriverLeaderboardViewModel } from '../../view-models';
+import type { DriverViewModel } from '../../view-models/DriverViewModel';
+import type { CompleteOnboardingViewModel } from '../../view-models/CompleteOnboardingViewModel';
+import type { CompleteOnboardingInputDto } from '../../dtos';
 
 /**
  * Driver Service
  *
- * Handles driver-related operations including profiles, leaderboards, and onboarding.
+ * Orchestrates driver operations by coordinating API calls and presentation logic.
+ * All dependencies are injected via constructor.
  */
 export class DriverService {
   constructor(
-    private readonly apiClient = api.drivers
+    private readonly apiClient: DriversApiClient,
+    private readonly leaderboardPresenter: DriversLeaderboardPresenter,
+    private readonly driverPresenter: DriverPresenter,
+    private readonly onboardingPresenter: CompleteOnboardingPresenter
   ) {}
 
+  /**
+   * Get driver leaderboard with presentation transformation
+   */
   async getDriverLeaderboard(): Promise<DriverLeaderboardViewModel> {
     const dto = await this.apiClient.getLeaderboard();
-    return presentDriversLeaderboard(dto);
+    return this.leaderboardPresenter.present(dto);
   }
 
-  async completeDriverOnboarding(input: any): Promise<any> {
-    return await this.apiClient.completeOnboarding(input);
+  /**
+   * Complete driver onboarding with presentation transformation
+   */
+  async completeDriverOnboarding(input: CompleteOnboardingInputDto): Promise<CompleteOnboardingViewModel> {
+    const dto = await this.apiClient.completeOnboarding(input);
+    return this.onboardingPresenter.present(dto);
   }
 
-  async getCurrentDriver(): Promise<any> {
-    return await this.apiClient.getCurrent();
+  /**
+   * Get current driver with presentation transformation
+   */
+  async getCurrentDriver(): Promise<DriverViewModel | null> {
+    const dto = await this.apiClient.getCurrent();
+    if (!dto) {
+      return null;
+    }
+    return this.driverPresenter.present(dto);
   }
-}
-
-// Singleton instance
-export const driverService = new DriverService();
-
-// Backward compatibility functional exports
-export async function getDriverLeaderboard(): Promise<DriverLeaderboardViewModel> {
-  return driverService.getDriverLeaderboard();
-}
-
-export async function completeDriverOnboarding(input: any): Promise<any> {
-  return driverService.completeDriverOnboarding(input);
-}
-
-export async function getCurrentDriver(): Promise<any> {
-  return driverService.getCurrentDriver();
 }