From 29a414f385a4a70f50587b56585a5ef72c855993 Mon Sep 17 00:00:00 2001 From: Marc Mintel Date: Sat, 14 Feb 2026 15:34:54 +0100 Subject: [PATCH] fix(qa): resolve lint errors and unused variables across packages --- package.json | 3 +- packages/eslint-config/index.js | 10 ++ .../src/components/pdf/SharedUI.tsx | 4 +- .../pdf/modules/BrandingModules.tsx | 1 - pnpm-lock.yaml | 129 ++---------------- scripts/sync-versions.ts | 2 +- 6 files changed, 29 insertions(+), 120 deletions(-) diff --git a/package.json b/package.json index 9191fc3..45d7c7d 100644 --- a/package.json +++ b/package.json @@ -29,6 +29,7 @@ "@commitlint/config-conventional": "^20.4.0", "@mintel/eslint-config": "workspace:*", "@mintel/husky-config": "workspace:*", + "@next/eslint-plugin-next": "16.1.6", "@testing-library/jest-dom": "^6.9.1", "@testing-library/react": "^16.3.2", "@types/node": "^20.17.16", @@ -36,7 +37,6 @@ "@types/react-dom": "^19.2.3", "@vitejs/plugin-react": "^5.1.2", "eslint": "^9.39.2", - "@next/eslint-plugin-next": "16.1.6", "eslint-plugin-react": "^7.37.5", "eslint-plugin-react-hooks": "^7.0.1", "happy-dom": "^20.4.0", @@ -50,6 +50,7 @@ "vitest": "^4.0.18" }, "dependencies": { + "globals": "^17.3.0", "import-in-the-middle": "^3.0.0", "pino": "^10.3.1", "pino-pretty": "^13.1.3", diff --git a/packages/eslint-config/index.js b/packages/eslint-config/index.js index 1bd89f9..32d32e9 100644 --- a/packages/eslint-config/index.js +++ b/packages/eslint-config/index.js @@ -1,7 +1,17 @@ import js from "@eslint/js"; import tseslint from "typescript-eslint"; +import globals from "globals"; export default tseslint.config( + { + languageOptions: { + globals: { + ...globals.browser, + ...globals.node, + ...globals.es2021, + }, + }, + }, { ignores: ["**/dist/**", "**/node_modules/**", "**/.next/**", "**/build/**"], }, diff --git a/packages/pdf-library/src/components/pdf/SharedUI.tsx b/packages/pdf-library/src/components/pdf/SharedUI.tsx index e5df20d..90aeb3b 100644 --- a/packages/pdf-library/src/components/pdf/SharedUI.tsx +++ b/packages/pdf-library/src/components/pdf/SharedUI.tsx @@ -525,13 +525,13 @@ export const FoldingMarks = () => ( export const Footer = ({ logo, companyData, - bankData, + _bankData, showDetails = true, showPageNumber = true, }: { logo?: string; companyData: any; - bankData?: any; + _bankData?: any; showDetails?: boolean; showPageNumber?: boolean; }) => ( diff --git a/packages/pdf-library/src/components/pdf/modules/BrandingModules.tsx b/packages/pdf-library/src/components/pdf/modules/BrandingModules.tsx index daf007f..089978a 100644 --- a/packages/pdf-library/src/components/pdf/modules/BrandingModules.tsx +++ b/packages/pdf-library/src/components/pdf/modules/BrandingModules.tsx @@ -8,7 +8,6 @@ import { } from "@react-pdf/renderer"; import { DocumentTitle, - IndustrialListItem, IndustrialCard, Divider, COLORS, diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 24b9e54..1aa86c4 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -12,6 +12,9 @@ importers: .: dependencies: + globals: + specifier: ^17.3.0 + version: 17.3.0 import-in-the-middle: specifier: ^3.0.0 version: 3.0.0 @@ -161,7 +164,7 @@ importers: devDependencies: '@directus/extensions-sdk': specifier: 11.0.2 - version: 11.0.2(@types/node@22.19.10)(@unhead/vue@1.11.20(vue@3.4.21(typescript@5.9.3)))(knex@3.1.0)(lightningcss@1.30.2)(pinia@2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)))(pino@10.3.1)(sass@1.97.3)(terser@5.46.0)(typescript@5.9.3) + version: 11.0.2(@types/node@22.19.10)(@unhead/vue@1.11.20(vue@3.5.28(typescript@5.9.3)))(knex@3.1.0)(lightningcss@1.30.2)(pinia@2.3.1(typescript@5.9.3)(vue@3.5.28(typescript@5.9.3)))(pino@10.3.1)(sass@1.97.3)(terser@5.46.0)(typescript@5.9.3) '@mintel/mail': specifier: workspace:* version: link:../mail @@ -437,7 +440,7 @@ importers: version: 5.9.3 vitest: specifier: ^3.0.4 - version: 3.2.4(@types/debug@4.1.12)(@types/node@22.19.10)(@vitest/ui@4.0.18)(happy-dom@20.5.3)(jsdom@27.4.0)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0) + version: 3.2.4(@types/debug@4.1.12)(@types/node@22.19.10)(@vitest/ui@4.0.18(vitest@4.0.18))(happy-dom@20.5.3)(jsdom@27.4.0)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0) packages/next-config: dependencies: @@ -599,7 +602,7 @@ importers: version: 5.9.3 vitest: specifier: ^2.0.0 - version: 2.1.9(@types/node@22.19.10)(@vitest/ui@4.0.18)(happy-dom@20.5.3)(jsdom@27.4.0)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0) + version: 2.1.9(@types/node@22.19.10)(@vitest/ui@4.0.18(vitest@4.0.18))(happy-dom@20.5.3)(jsdom@27.4.0)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0) packages/pdf-library: dependencies: @@ -5121,6 +5124,10 @@ packages: resolution: {integrity: sha512-ob/2LcVVaVGCYN+r14cnwnoDPUufjiYgSqRhiFD0Q1iI4Odora5RE8Iv1D24hAz5oMophRGkGz+yuvQmmUMnMw==} engines: {node: '>=18'} + globals@17.3.0: + resolution: {integrity: sha512-yMqGUQVVCkD4tqjOJf3TnrvaaHDMYp4VlUSObbkIiuCPe/ofdMBFIAcBbCSRFWOnos6qRiTVStDwqPLUclaxIw==} + engines: {node: '>=18'} + globalthis@1.0.4: resolution: {integrity: sha512-DpLKbNU4WylpxJykQujfCcwYWiV/Jhm50Goo0wrVILAv5jOr9d+H+UR3PhSCD2rCCEIg0uc+G+muBTwD54JhDQ==} engines: {node: '>= 0.4'} @@ -8815,57 +8822,6 @@ snapshots: '@directus/constants@11.0.3': {} - '@directus/extensions-sdk@11.0.2(@types/node@22.19.10)(@unhead/vue@1.11.20(vue@3.4.21(typescript@5.9.3)))(knex@3.1.0)(lightningcss@1.30.2)(pinia@2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)))(pino@10.3.1)(sass@1.97.3)(terser@5.46.0)(typescript@5.9.3)': - dependencies: - '@directus/composables': 10.1.12(vue@3.4.21(typescript@5.9.3)) - '@directus/constants': 11.0.3 - '@directus/extensions': 1.0.2(@unhead/vue@1.11.20(vue@3.4.21(typescript@5.9.3)))(knex@3.1.0)(pinia@2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)))(pino@10.3.1)(vue@3.4.21(typescript@5.9.3)) - '@directus/themes': 0.3.6(@unhead/vue@1.11.20(vue@3.4.21(typescript@5.9.3)))(pinia@2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)))(vue@3.4.21(typescript@5.9.3)) - '@directus/types': 11.0.8(knex@3.1.0)(vue@3.4.21(typescript@5.9.3)) - '@directus/utils': 11.0.7(vue@3.4.21(typescript@5.9.3)) - '@rollup/plugin-commonjs': 25.0.7(rollup@3.29.4) - '@rollup/plugin-json': 6.1.0(rollup@3.29.4) - '@rollup/plugin-node-resolve': 15.2.3(rollup@3.29.4) - '@rollup/plugin-replace': 5.0.5(rollup@3.29.4) - '@rollup/plugin-terser': 0.4.4(rollup@3.29.4) - '@rollup/plugin-virtual': 3.0.2(rollup@3.29.4) - '@vitejs/plugin-vue': 4.6.2(vite@4.5.2(@types/node@22.19.10)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0))(vue@3.4.21(typescript@5.9.3)) - chalk: 5.3.0 - commander: 10.0.1 - esbuild: 0.17.19 - execa: 7.2.0 - fs-extra: 11.2.0 - inquirer: 9.2.16 - ora: 6.3.1 - rollup: 3.29.4 - rollup-plugin-esbuild: 5.0.0(esbuild@0.17.19)(rollup@3.29.4) - rollup-plugin-styles: 4.0.0(rollup@3.29.4) - vite: 4.5.2(@types/node@22.19.10)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0) - vue: 3.4.21(typescript@5.9.3) - transitivePeerDependencies: - - '@types/node' - - '@unhead/vue' - - better-sqlite3 - - debug - - knex - - less - - lightningcss - - mysql - - mysql2 - - pg - - pg-native - - pinia - - pino - - sass - - sqlite3 - - stylus - - sugarss - - supports-color - - tedious - - terser - - typescript - - vue-router - '@directus/extensions-sdk@11.0.2(@types/node@22.19.10)(@unhead/vue@1.11.20(vue@3.5.28(typescript@5.9.3)))(knex@3.1.0)(lightningcss@1.30.2)(pinia@2.3.1(typescript@5.9.3)(vue@3.5.28(typescript@5.9.3)))(pino@10.3.1)(sass@1.97.3)(terser@5.46.0)(typescript@5.9.3)': dependencies: '@directus/composables': 10.1.12(vue@3.4.21(typescript@5.9.3)) @@ -8917,32 +8873,6 @@ snapshots: - typescript - vue-router - '@directus/extensions@1.0.2(@unhead/vue@1.11.20(vue@3.4.21(typescript@5.9.3)))(knex@3.1.0)(pinia@2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)))(pino@10.3.1)(vue@3.4.21(typescript@5.9.3))': - dependencies: - '@directus/constants': 11.0.3 - '@directus/themes': 0.3.6(@unhead/vue@1.11.20(vue@3.4.21(typescript@5.9.3)))(pinia@2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)))(vue@3.4.21(typescript@5.9.3)) - '@directus/types': 11.0.8(knex@3.1.0)(vue@3.4.21(typescript@5.9.3)) - '@directus/utils': 11.0.7(vue@3.4.21(typescript@5.9.3)) - '@types/express': 4.17.21 - fs-extra: 11.2.0 - lodash-es: 4.17.21 - zod: 3.22.4 - optionalDependencies: - knex: 3.1.0 - pino: 10.3.1 - vue: 3.4.21(typescript@5.9.3) - transitivePeerDependencies: - - '@unhead/vue' - - better-sqlite3 - - mysql - - mysql2 - - pg - - pg-native - - pinia - - sqlite3 - - supports-color - - tedious - '@directus/extensions@1.0.2(@unhead/vue@1.11.20(vue@3.5.28(typescript@5.9.3)))(knex@3.1.0)(pinia@2.3.1(typescript@5.9.3)(vue@3.5.28(typescript@5.9.3)))(pino@10.3.1)(vue@3.4.21(typescript@5.9.3))': dependencies: '@directus/constants': 11.0.3 @@ -8986,17 +8916,6 @@ snapshots: '@directus/system-data@1.0.2': {} - '@directus/themes@0.3.6(@unhead/vue@1.11.20(vue@3.4.21(typescript@5.9.3)))(pinia@2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)))(vue@3.4.21(typescript@5.9.3))': - dependencies: - '@directus/utils': 11.0.7(vue@3.4.21(typescript@5.9.3)) - '@sinclair/typebox': 0.32.15 - '@unhead/vue': 1.11.20(vue@3.4.21(typescript@5.9.3)) - decamelize: 6.0.0 - flat: 6.0.1 - lodash-es: 4.17.21 - pinia: 2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)) - vue: 3.4.21(typescript@5.9.3) - '@directus/themes@0.3.6(@unhead/vue@1.11.20(vue@3.5.28(typescript@5.9.3)))(pinia@2.3.1(typescript@5.9.3)(vue@3.5.28(typescript@5.9.3)))(vue@3.4.21(typescript@5.9.3))': dependencies: '@directus/utils': 11.0.7(vue@3.4.21(typescript@5.9.3)) @@ -11088,14 +11007,6 @@ snapshots: '@unhead/schema': 1.11.20 packrup: 0.1.2 - '@unhead/vue@1.11.20(vue@3.4.21(typescript@5.9.3))': - dependencies: - '@unhead/schema': 1.11.20 - '@unhead/shared': 1.11.20 - hookable: 5.5.3 - unhead: 1.11.20 - vue: 3.4.21(typescript@5.9.3) - '@unhead/vue@1.11.20(vue@3.5.28(typescript@5.9.3))': dependencies: '@unhead/schema': 1.11.20 @@ -13211,6 +13122,8 @@ snapshots: globals@16.4.0: {} + globals@17.3.0: {} + globalthis@1.0.4: dependencies: define-properties: 1.2.1 @@ -14526,16 +14439,6 @@ snapshots: pify@4.0.1: {} - pinia@2.3.1(typescript@5.9.3)(vue@3.4.21(typescript@5.9.3)): - dependencies: - '@vue/devtools-api': 6.6.4 - vue: 3.4.21(typescript@5.9.3) - vue-demi: 0.14.10(vue@3.4.21(typescript@5.9.3)) - optionalDependencies: - typescript: 5.9.3 - transitivePeerDependencies: - - '@vue/composition-api' - pinia@2.3.1(typescript@5.9.3)(vue@3.5.28(typescript@5.9.3)): dependencies: '@vue/devtools-api': 6.6.4 @@ -16016,7 +15919,7 @@ snapshots: tsx: 4.21.0 yaml: 2.8.2 - vitest@2.1.9(@types/node@22.19.10)(@vitest/ui@4.0.18)(happy-dom@20.5.3)(jsdom@27.4.0)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0): + vitest@2.1.9(@types/node@22.19.10)(@vitest/ui@4.0.18(vitest@4.0.18))(happy-dom@20.5.3)(jsdom@27.4.0)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0): dependencies: '@vitest/expect': 2.1.9 '@vitest/mocker': 2.1.9(vite@5.4.21(@types/node@22.19.10)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0)) @@ -16054,7 +15957,7 @@ snapshots: - supports-color - terser - vitest@3.2.4(@types/debug@4.1.12)(@types/node@22.19.10)(@vitest/ui@4.0.18)(happy-dom@20.5.3)(jsdom@27.4.0)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0): + vitest@3.2.4(@types/debug@4.1.12)(@types/node@22.19.10)(@vitest/ui@4.0.18(vitest@4.0.18))(happy-dom@20.5.3)(jsdom@27.4.0)(lightningcss@1.30.2)(sass@1.97.3)(terser@5.46.0): dependencies: '@types/chai': 5.2.3 '@vitest/expect': 3.2.4 @@ -16137,10 +16040,6 @@ snapshots: - tsx - yaml - vue-demi@0.14.10(vue@3.4.21(typescript@5.9.3)): - dependencies: - vue: 3.4.21(typescript@5.9.3) - vue-demi@0.14.10(vue@3.5.28(typescript@5.9.3)): dependencies: vue: 3.5.28(typescript@5.9.3) diff --git a/scripts/sync-versions.ts b/scripts/sync-versions.ts index 2a63fb6..260254f 100644 --- a/scripts/sync-versions.ts +++ b/scripts/sync-versions.ts @@ -32,7 +32,7 @@ function getVersionTag() { if (gitTag && gitTag.match(/^v?\d/)) { return gitTag; } - } catch (e) { + } catch (_e) { // Fallback or silence }